Add chassis type to support new type of device (Bugfix)#2043
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2043 +/- ##
=======================================
Coverage 51.53% 51.53%
=======================================
Files 385 385
Lines 41440 41440
Branches 7709 7709
=======================================
Hits 21357 21357
Misses 19321 19321
Partials 762 762
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Hook25
approved these changes
Jul 25, 2025
Collaborator
|
Note: this is ok, but in the future we may want to create a manfiest for has_lid |
stanley31huang
pushed a commit
that referenced
this pull request
Aug 14, 2025
Add new chassis type for graphic, monitor and power management test cases
bladernr
pushed a commit
that referenced
this pull request
Aug 28, 2025
Add new chassis type for graphic, monitor and power management test cases
stanley31huang
pushed a commit
that referenced
this pull request
Oct 3, 2025
Add new chassis type for graphic, monitor and power management test cases
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There is one new type of device has to be enabled and we notice that some test cases could not be executed on it.
add
TabletandDetachableto require chassisadd
TabletandDetachableto require chassisadd
TabletandDetachableto require chassisadd
TabletandDetachableto require chassisadd
TabletandDetachableto require chassisadd
Detachableto require chassisChange to align the same requirement to
id: power-management/lidadd
TabletandDetachableto require chassisResolved issues
Documentation
Tests